Add option to generate ES module file #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chomiciak
suggested changes
Feb 18, 2025
| @@ -254,7 +254,7 @@ public function testShouldIgnoreDefaultOutputPathFromConfigIfTargetArgumentExist | |||
| * */ | |||
| public function testShouldTemplateMessagesHasHandlebars() | |||
| { | |||
| $template = "$this->rootPath/src/Mariuzzo/LaravelJsLocalization/Generators/Templates/messages.js"; | |||
| $template = "$this->rootPath/src/Mariuzzo/LaravelJsLocalization/Generators/Templates/messages.cjs"; | |||
There was a problem hiding this comment.
There should be a separate test performed for the .mjs file, leaving the previous unchanged
Comment on lines
+77
to
+81
| if ($options['module']) { | ||
| $template = $this->file->get(__DIR__.'/Templates/messages.mjs'); | ||
| } else { | ||
| $template = $this->file->get(__DIR__.'/Templates/messages.cjs'); | ||
| } |
There was a problem hiding this comment.
This is a breaking change as it changes the default file name extension from .js to .cjs
There was a problem hiding this comment.
Please change the extension back to .js for when the option is not set to maintain compatibility. Otherwise this should be scheduled to major version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.