Remove deprecated spider argument from StatsCollector.inc_value() calls#309
Merged
Conversation
Agent-Logs-Url: https://github.com/rmax/scrapy-redis/sessions/ee1c42d3-7bcd-4e95-a118-2d2fe4ab27c5 Co-authored-by: rmax <26015+rmax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ScrapyDeprecationWarning for StatsCollector.inc_value
Remove deprecated Apr 7, 2026
spider argument from StatsCollector.inc_value() calls
There was a problem hiding this comment.
Pull request overview
Removes deprecated spider keyword usage in StatsCollector.inc_value() calls to avoid ScrapyDeprecationWarning during Redis scheduler enqueue/dequeue operations.
Changes:
- Drop
spider=self.spiderfrom thescheduler/enqueued/redisstats increment. - Drop
spider=self.spiderfrom thescheduler/dequeued/redisstats increment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrapy deprecated passing a
spiderargument toStatsCollector.inc_value()and will remove it in a future version, causingScrapyDeprecationWarningon every enqueue/dequeue operation.Changes
scheduler.py: Dropspider=self.spiderfrom bothinc_valuecalls: