Accept blocks to reference schema root types #5055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the schema could defer loading a root type until necessary (thus also deferring loading all types referenced by it, resolvers, etc).
In this implementation, calling
schema.query
returns the deferred definition which means that if, say, a plug-in references that root type, all the magic is lost.To be really effective, we'd also need some plugin behavior like
extend(:query) { ... }
where callbacks could be registered by the plugin, then called by GraphQL-Ruby after the type is actually loaded. I think that can be added later.Part of #5014
TODO:
types/query.rb
until a query is run when usingSchema::Subset
.