Skip to content

Fix Dataloader#with for JRuby#5616

Merged
rmosolgo merged 1 commit intomasterfrom
jruby-args-fix
Apr 29, 2026
Merged

Fix Dataloader#with for JRuby#5616
rmosolgo merged 1 commit intomasterfrom
jruby-args-fix

Conversation

@rmosolgo
Copy link
Copy Markdown
Owner

Fixes #5541

Apparently JRuby 10+ handles this fine, so I reworked these conditionals to allow it to use the else branch instead. I ran the script from #5541 and it passed with this change:

RUBY_ENGINE: jruby
RUBY_VERSION: 3.4.5
graphql gem version: 2.6.1

Attempting: dataloader.with(KeywordSource, name: 'test', value: 42).load('key1')
SUCCESS: "test:42:key1"

I don't have any JRuby or TruffleRuby CI set up, though 🙈

I got the RUBY_ENGINE value for TruffleRuby ("truffleruby") here: https://www.graalvm.org/22.0/reference-manual/ruby/Compatibility/

@rmosolgo rmosolgo added this to the 2.6.2 milestone Apr 29, 2026
@rmosolgo rmosolgo merged commit dec3c72 into master Apr 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataloader#with doesn't forward keyword arguments on non-MRI engines (JRuby 10)

1 participant