Add defcustom to configure a path between host and filename#92
Open
jvtrigueros wants to merge 3 commits into
Open
Add defcustom to configure a path between host and filename#92jvtrigueros wants to merge 3 commits into
jvtrigueros wants to merge 3 commits into
Conversation
|
Could this be generalized to a full host replacement? I'm looking into a fix for #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue where my remote type was using
gitilestype, but between the host and the filename there was a custom path. At first, I tried to solve this withadd-advicebut it quickly became a mess, so it was much easier to provide this as an option.browse-at-remote-append-path-to-hostallows users of the package to customize the remote URL if needed:This is my first PR to an emacs package so I'm not sure if this is the best way to go about it.