#14-#16 Backend:add post mongo repository service controller #21

olegbal · 2017-06-17T16:26:48Z

No description provided.

…tService

…dd PostController tests without implementation.

solairerove · 2017-06-17T16:28:15Z

src/main/java/com/github/dregheap/controller/PostController.java

+import java.awt.print.Pageable;
+
+@RestController
+@RequestMapping(path = "/api/v1/posts")


solairerove · 2017-06-17T16:28:29Z

src/main/java/com/github/dregheap/controller/PostController.java

+        return new ResponseEntity(HttpStatus.OK);
+    }
+
+    @RequestMapping(method = RequestMethod.GET, params = {"page", "size"})


solairerove · 2017-06-17T16:28:44Z

src/main/java/com/github/dregheap/model/Post.java

+import org.springframework.data.annotation.Id;
+import org.springframework.data.mongodb.core.mapping.Document;
+
+@Document(collection = "posts")


…s in tests.

… to controller. Make responseEntity type generic.

…hem.

… postcontroller.

vlsidlyarevich · 2017-07-05T06:06:35Z

src/main/java/com/github/dregheap/controller/HelloController.java

@@ -12,6 +12,6 @@

    @RequestMapping(method = RequestMethod.GET)
    public ResponseEntity getHelloMessage() {
-        return new ResponseEntity("Hello world!", HttpStatus.OK);
+        return new ResponseEntity<>("Hello world!", HttpStatus.OK);


For removing warning "Unchecked call"

vlsidlyarevich · 2017-07-05T06:07:17Z

src/main/java/com/github/dregheap/controller/PostController.java

+
+
+@RestController
+@RequiredArgsConstructor


add @Autowired on constructor for more visibility

vlsidlyarevich · 2017-07-05T06:08:02Z

src/main/java/com/github/dregheap/controller/PostController.java

+
+    @RequestMapping(method = RequestMethod.PUT, consumes = {MediaType.APPLICATION_JSON_VALUE})
+    public ResponseEntity updatePost(@RequestBody Post post) {
+        return new ResponseEntity<>(postService.update(post), HttpStatus.NO_CONTENT);


Why NO_CONTENT?

vlsidlyarevich · 2017-07-05T06:08:13Z

src/main/java/com/github/dregheap/controller/PostController.java

+    @RequestMapping(path = "/{id}", method = RequestMethod.DELETE)
+    public ResponseEntity deletePostById(@PathVariable String id) {
+        postService.deleteById(id);
+        return new ResponseEntity(HttpStatus.OK);


https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html

vlsidlyarevich · 2017-07-05T06:08:25Z

src/main/java/com/github/dregheap/controller/PostController.java

+    @RequestMapping(method = RequestMethod.DELETE, consumes = {MediaType.APPLICATION_JSON_VALUE})
+    public ResponseEntity deletePost(@RequestBody Post post) {
+        postService.delete(post);
+        return new ResponseEntity(HttpStatus.OK);


https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html

vlsidlyarevich · 2017-07-05T06:08:48Z

src/main/java/com/github/dregheap/model/Post.java

+    private String topicId;
+    private String postMessage;
+
+    public Post() {


Why empty constructor? For what?

vlsidlyarevich · 2017-07-05T06:09:10Z

src/main/java/com/github/dregheap/service/DefaultPostService.java

+import java.util.List;
+
+@Service
+@RequiredArgsConstructor


Add @Autowired over constructor

vlsidlyarevich · 2017-07-05T06:09:45Z

src/main/java/com/github/dregheap/service/DefaultPostService.java

+
+    @Override
+    public Post create(Post post) {
+        post.setId(null);


Null?? For what?

For prevent updating of object with the same id as in request body. This method is only for creating new objects in db.

vlsidlyarevich · 2017-07-05T06:10:13Z

src/main/java/com/github/dregheap/service/DefaultPostService.java

+    }
+
+    @Override
+    public Post create(Post post) {


What if post is null?

vlsidlyarevich · 2017-07-05T06:11:22Z

src/test/java/com/github/dregheap/controller/PostControllerTest.java

+
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.when;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;


Don't use star imports

vlsidlyarevich · 2017-07-05T06:23:10Z

src/test/java/com/github/dregheap/controller/PostControllerTest.java

+
+    @Test
+    public void createPostShouldReturnStatusCreated() throws Exception {
+        Post creatingPost = new Post();


Separate that

vlsidlyarevich · 2017-07-05T06:23:31Z

src/test/java/com/github/dregheap/service/PostServiceTest.java

+    @Mock
+    private PostRepository postRepository;
+
+    PostService postService;


Package access?

vlsidlyarevich · 2017-07-05T06:24:00Z

src/test/java/com/github/dregheap/service/PostServiceTest.java

+
+    @Test
+    public void getAllPostsShouldReturnPostsList() {
+


Don't do that empty lines, nowhere

….MockMvcRequestBuilders.* and add only using imports of this package.

… Remove warnings.

solairerove · 2017-07-08T22:19:00Z

why so long conversation, mmm?

solairerove · 2017-07-08T22:28:28Z

use cherry pick to separate issues/

olegbal added 5 commits June 17, 2017 19:15

#14 add PostRepository class

590631a

#15 - Add PostService interface and implementation. Add tests for Pos…

b276c4d

…tService

#16 - Rename package controllers to controller. Add PostController. A…

6e7f3a9

…dd PostController tests without implementation.

Add Post model. Add mongodb connection url to application.yml config

1d390c8

Update spring-boot version to 1.5.4. Add mongodb dependency

10b5fc6

solairerove reviewed Jun 17, 2017

View reviewed changes

olegbal changed the title ~~#14 16 backend add post mongo repository service controller~~ #14-#16 Backend:add post mongo repository service controller Jun 17, 2017

olegbal added 9 commits July 1, 2017 19:31

#14 - Change Id type from Long to String

0e38a1e

#15 - Additional methods. Rename some methods.

40ba8f5

#16 - Add consuming media types.

b2a500f

Add lombock dependency.

85692eb

#15 - Add RequiredArgsConstructor lombock annotation. Fix method name…

6e7d512

…s in tests.

#16 - Add RequiredArgsConstructor lombock annotation. Add new methods…

1137322

… to controller. Make responseEntity type generic.

Remove getters and setters. Add @DaTa lombock annotation instead of t…

10b22c7

…hem.

#16 - Rename PostController test to PostControllerTest. Add tests for…

4d7be50

… postcontroller.

Remove System.out.printl.

8f7d249

vlsidlyarevich reviewed Jul 5, 2017

View reviewed changes

olegbal added 7 commits July 5, 2017 10:03

Add @Autowired annotation for constructors.

3132d31

Move postService.update(post) method out of ResponseEntity

1b40298

Delete no-args constructor.

e1823c1

Optimize imports. Remove org.springframework.test.web.servlet.request…

a0e9523

….MockMvcRequestBuilders.* and add only using imports of this package.

Remove empty lines between class declaration and it's implementation.…

845cefa

… Remove warnings.

Remove empty lines between class declaration and it's implementation.…

cdcd52f

… Remove warnings.

Remove empty lines between class declaration and it's implementation.…

ff94988

… Remove warnings.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#14-#16 Backend:add post mongo repository service controller #21

#14-#16 Backend:add post mongo repository service controller #21

olegbal commented Jun 17, 2017

solairerove Jun 17, 2017

solairerove Jun 17, 2017

solairerove Jun 17, 2017

vlsidlyarevich Jul 5, 2017

olegbal Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

olegbal Aug 21, 2017

vlsidlyarevich Jul 5, 2017

olegbal Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

olegbal Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

vlsidlyarevich Jul 5, 2017

solairerove commented Jul 8, 2017

solairerove commented Jul 8, 2017



		@RestController
		@RequiredArgsConstructor

#14-#16 Backend:add post mongo repository service controller #21

Are you sure you want to change the base?

#14-#16 Backend:add post mongo repository service controller #21

Conversation

olegbal commented Jun 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

solairerove commented Jul 8, 2017

solairerove commented Jul 8, 2017