Hide privates #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterNordin
force-pushed
the
hide_privates
branch
2 times, most recently
from
59383bc to
f145b76
Compare
Was using wrong target name after zlib update
First use may otherwise contain garbage values
…c line below is using int64
This reverts commit 3bbcae7.
peterNordin
force-pushed
the
hide_privates
branch
from
3704916 to
35c6788
Compare
Owner
|
Is this PR still relevant? I believe much of it has been covered by other PRs and it feels like it would be quite painful to rebase this now... |
Collaborator
Author
|
No not relevant but most of the commits here are due to rebase maybe I will clean it up at some point and update this PR. But not important. I think my intention was to hide those things which are internal and private from the public API. But I do not remeber exactly why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.