Skip to content

Added ability to build over multiple architectures (arm64/amd64) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jijiechen
Copy link

Hi thanks for the great work on making the OpenSSH image!
I encountered some issues when running the image on a ARM architectore OS, my environment was on docker desktop on a M1 Mac.

So this PR is to make the Dockerfile support multi-arch building.

Here is an generated image with OpenSSH that works on both ARM64 and AMD64, if anyone just want to pull and use:

docker pull jijiechen/centos8-openssh:202312

Copy link
Owner

@robertdebock robertdebock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good feature, I've placed some inline comment, specifically about the default value of TARGETARG. Can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants