Update "url" dependency and disable IDNA support#163
Merged
robertknight merged 1 commit intomainfrom Feb 8, 2025
Merged
Conversation
Update "url" dependency to the current version in ocrs-cli, then disable IDNA support to eliminate 20+ (!) dependencies. Disabling IDNA support uses the mechanism described at https://docs.rs/crate/idna_adapter/latest, which is to pin "idna_adapter" to a specific version. For reference, ocrs-cli uses the URL dependency only to extract the last path segment from a URL to use as a filename.
Owner
Author
|
Unfortunately |
robertknight
added a commit
that referenced
this pull request
Feb 9, 2025
I was surprised to learn that `cargo install` does not respect a binary package's lockfile by default [^1] and will attempt to upgrade dependencies. Aside from installing package combinations that haven't been directly tested, this also undoes the change in [^2] to avoid installing Unicode-related dependencies. Specifying `--locked` when installing is thus both safer and faster. [^1]: https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile [^2]: #163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update "url" dependency to the current version in ocrs-cli, then disable IDNA support to eliminate 20+ (!) dependencies. Disabling IDNA support uses the mechanism described at https://docs.rs/crate/idna_adapter/latest, which is to pin "idna_adapter" to a specific version:
For reference, ocrs-cli uses the URL dependency only to extract the last path segment from a URL to use as a filename.
An annoying downside of this change is that
cargo updatewith no arguments will undo the pin.