Support start and end attributes for Shape operator
#648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
robertknight
force-pushed
the
shape-start-end-attrs
branch
from
8b22e13 to
130f493
Compare
- Support attributes for `Shape` operator in rten model files. This is optional for backwards compatibility. - Support `start` and `end` attributes in `Shape` op implementation
robertknight
force-pushed
the
shape-start-end-attrs
branch
from
130f493 to
acbd980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shapeoperator in rten model files. This is optional for backwards compatibility.startandendattributes inShapeop implementationTODO:
startandendvalues to be out of range, in which case they are clamped, per the spec