Only emit one error for each unsupported operator encountered #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give this utility a name which matches its functionality better.
If an unsupported operator is used by many nodes, only emit one message per operator. This makes the output less noisy. - Add `ConversionError` base class for all exceptions during conversion - Add `UnsupportedOperatorError` subclass for unsupported operator exceptions and use this to keep a memory of the unique operators for which a warning has been emitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During model conversion, if an unsupported operator is used by many nodes, only emit one message per operator type. This makes the output less noisy.
Add
ConversionErrorbase class for all exceptions during conversionAdd
UnsupportedOperatorErrorsubclass for unsupported operatorexceptions and use this to keep a memory of the unique operators for
which a warning has been emitted.