Improve Split operator implementation, add TensorBase::{slice_axis, slice_axis_mut}
#657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are useful for splitting a tensor into chunks along a given axis. In the process `Layout::slice_axis` was changed to add bounds checks on the axis and range, returning a `SliceError` if these are invalid. This in turn makes `slice_axis` fail earlier and with a better error if the arguments are invalid.
Using `slice_axis` in this context is more efficient and simpler to use than the more general-purpose `slice` method.
robertknight
force-pushed
the
split-slice-axis
branch
from
ce72ee1 to
4fd720d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the
Splitoperator was clunky and inefficient as it constructed a dynamically sized set of arguments forTensorBase::slice. Internally rten-tensor had a more ergonomic and efficient API for slicing a tensor along an axis. Expose and add tests for this API, and use it in theSplitoperator implementation.This change will also make it easier to add support for the
num_outputsattribute in the Split operator.