Fix error when reducing multiple axes if reduced chunks are non-contiguous #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
fix-reduce-multiple-axes
branch
from
f4b280b to
03fe119
Compare
…guous Fix a bounds check error when slicing `tmp_buf` if: - The input is contiguous - Multiple axes are reduced - The reduced slices are non-contiguous In this case the code expected capacity to have been reserved in `tmp_buf` but it was actually empty. Change how the buffer is allocated to ensure it is always allocated when needed.
robertknight
force-pushed
the
fix-reduce-multiple-axes
branch
from
03fe119 to
3e20ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bounds check error when slicing
tmp_bufif multiple axes are reduced and the reduced slices are non-contiguous. In this case the code expected capacity to have been reserved intmp_bufbut it was actually empty. Change how the buffer is allocated to ensure it is always allocated when needed.