Fix optimality when negative values are in use#105
Merged
robertknight merged 1 commit intorobertknight:masterfrom Aug 3, 2025
Merged
Fix optimality when negative values are in use#105robertknight merged 1 commit intorobertknight:masterfrom
robertknight merged 1 commit intorobertknight:masterfrom
Conversation
robertknight
approved these changes
Aug 3, 2025
Owner
robertknight
left a comment
There was a problem hiding this comment.
Thanks again for the detailed notes.
| // | ||
| // Line-length = 10 | ||
| // | ||
| // ┌─12─┐○───────○┌─-2─┐○────○┌──9──┐○──────○ |
Owner
There was a problem hiding this comment.
I missed that the middle box had a width of -2 rather than 2 until I read the code below.
Contributor
Author
|
Thanks @robertknight! Could this please be released? |
Owner
Contributor
Author
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@robertknight I spoke too soon in #103. We were fine against restriction 2, but not against restriction 1: a particular optimization relied on restriction 1. I've fixed that here by removing that optimization when restriction 1 is present. It is demonstrated in a new unit test, which fails like this before the fix to
src/layout.ts:After the fix to
src/layout.ts, the new unit test passes. While I was here, I also added comments explaining the reasoning for why we are safe with regard to both Restrictions 1 and 2.