-
Notifications
You must be signed in to change notification settings - Fork 3
[Snyk] Security upgrade ch.qos.logback:logback-classic from 1.4.7 to 1.5.14 #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-CHQOSLOGBACK-13169722
Summary of ChangesHello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR, automatically generated by Snyk, upgrades the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, addresses a security vulnerability by upgrading logback-classic. While this is a crucial update, I've identified a potential issue with a transitive dependency that should be addressed to prevent possible runtime errors. Please see my detailed comment below.
| <commons-io.version>2.14.0</commons-io.version> | ||
| <guava.version>32.1.3-jre</guava.version> | ||
| <logback-classic.version>1.4.7</logback-classic.version> | ||
| <logback-classic.version>1.5.14</logback-classic.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While upgrading logback-classic is important for security, this change introduces a potential dependency version mismatch.
The new version ch.qos.logback:logback-classic:1.5.14 depends on org.slf4j:slf4j-api:2.0.13. However, this project explicitly defines slf4j-api.version as 2.0.7 (on line 36), which will override the transitive dependency version due to Maven's dependency mediation.
Using an older version of slf4j-api than what logback-classic was built and tested against can lead to subtle bugs or runtime errors like NoSuchMethodError if logback-classic uses APIs introduced in slf4j-api after version 2.0.7.
To ensure compatibility and follow dependency management best practices, I recommend aligning the slf4j-api version. Please update the slf4j-api.version property on line 36 to 2.0.13.
Snyk has created this PR to fix 1 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):
pom.xmlVulnerabilities that will be fixed with an upgrade:
SNYK-JAVA-CHQOSLOGBACK-13169722
1.4.7->1.5.14No Known ExploitImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.