docs: remove content#199
Conversation
- Move virtual-cloud.mdx to docs section and rewrite with open source tone - Remove pricing, early-access, vs-localstack, and cloudmirror pages - Remove early access link from header navigation - Simplify GetStartedModal to show only CLI installation - Update navigation metadata for new page structure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request ReviewThis PR successfully repositions InfraSpec as an open-source infrastructure testing tool with a built-in emulator, removing commercial content and early access marketing. Strengths
Critical Issues Found
Suggestions
Security ReviewNo security concerns identified - no credentials exposed, HTTPS used appropriately. Code QualityLines: +214/-1,156 (net -942), Files: 12, Conventional commits: Yes Overall Quality: Good - needs minor formatting fixes before merge. RecommendationRequest Changes - fix the 5 critical issues above, then this will be ready to merge. |
PR Review: Documentation Refactoring for Open Source PositioningThis PR successfully repositions InfraSpec as an open-source project by removing commercial content and emphasizing the free, built-in Virtual Cloud emulator. The changes are well-aligned with the project's goals and improve clarity for users. ✅ Strengths1. Clear Messaging Transformation
2. Content Quality
3. Code Quality
4. Follows Project Standards
🐛 Issues Found1. CRITICAL: Broken YAML Formatting in GitLab CI Example
The GitLab CI code block is malformed: # Current (broken):
```yaml filename=".gitlab-ci.yml" test: image: golang:1.24 script: - curl -fsSL https://infraspec.sh/install.sh | bash
- infraspec features/ ```
# Should be:
```yaml filename=".gitlab-ci.yml"
test:
image: golang:1.24
script:
- curl -fsSL https://infraspec.sh/install.sh | bash
- infraspec features/Remove the comma before "of" - it creates an awkward pause. 3. Minor: Inconsistent Link Reference
The CloudMirror link uses # Current:
Weekly via [CloudMirror](/docs/cloudmirror)
# Better:
Weekly via [CloudMirror](/docs/virtual-cloud/cloudmirror)Same issue on line 185. 💡 Suggestions1. Missing Installation Script Validation The PR introduces
2. Consider Adding Metadata The new ---
title: Virtual Cloud Emulator
description: Test your infrastructure code with InfraSpec's built-in AWS emulator - fast, free, and zero setup required.
---3. Test Coverage Consideration The PR description mentions a test plan but doesn't indicate completion. Consider:
🔐 SecurityNo security concerns identified:
📊 Performance
🎯 Overall AssessmentThis is a well-executed refactoring that successfully achieves its goals. The critical YAML formatting issue should be fixed before merging, but otherwise the changes are solid. Recommendation: Approve with required changes Fix the GitLab CI YAML formatting issue, then this is ready to merge. Review completed using repository's CLAUDE.md guidelines |
PR Review: Documentation Cleanup and Open Source PositioningThank you for this significant documentation restructure! This is a positive move toward clarifying InfraSpec's open source positioning. Here's my detailed review: ✅ StrengthsStrong Strategic Direction
Quality Documentation
Code Quality
🐛 Issues Found1. Broken Link Reference (Medium Priority)Location: website/src/content/docs/virtual-cloud/overview.mdx:145 The comparison table references CloudMirror with /docs/cloudmirror but the file has been moved to /docs/virtual-cloud/cloudmirror. Fix: Update to CloudMirror for consistency. 2. GitLab CI YAML Formatting Error (High Priority)Location: website/src/content/docs/virtual-cloud/overview.mdx:111 The GitLab CI example has malformed YAML on line 111. It is all on one line instead of properly formatted. Should be: test:
image: golang:1.24
script:
- curl -fsSL https://infraspec.sh/install.sh | bash
- infraspec features/3. Inconsistent Whitespace (Low Priority)Locations: website/src/content/docs/virtual-cloud/overview.mdx:28, 35, 108 There are mysterious {" "} blocks that appear to be unintentional JSX whitespace. These should be removed from:
4. Typo (Low Priority)Location: website/src/content/index.mdx:50 Typo on line 50: "InfaSpec" should be "InfraSpec" 5. Roadmap Grammar (Low Priority)Location: website/src/content/docs/roadmap.mdx:4 Minor grammar issue: "Below you'll find a high-level roadmap, of the planned features." Should be: "Below you'll find a high-level roadmap of the planned features." (remove comma) 🎯 RecommendationsContent Improvements
Technical Improvements
📋 Test Plan AdditionsIn addition to your test plan, please verify:
🎨 Code StyleAll changes follow project conventions from CLAUDE.md:
SummaryThis is a well-executed PR with clear strategic value. The main issues to address: High Priority:
Medium Priority: Low Priority: Once these are addressed, this will be ready to merge. Great work simplifying the messaging and focusing on the open source value proposition! 🚀 |
Summary
virtual-cloud.mdxto docs section and rewrite with open source tone, emphasizing the free built-in emulatorChanges
website/src/content/docs/virtual-cloud/website/src/content/docs/virtual-cloud/overview.mdxwebsite/src/content/docs/virtual-cloud/cloudmirror.mdxpricing.mdx,early-access.mdx,vs-localstack.mdxlayout.jsxGetStartedModal.tsxTest plan
npm run devin website directory to verify pages render correctly🤖 Generated with Claude Code