Skip to content

Conversation

@robmry
Copy link
Owner

@robmry robmry commented Apr 22, 2025

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@robmry robmry force-pushed the nftables branch 15 times, most recently from ad3325d to c3b1124 Compare April 28, 2025 15:38
@robmry robmry force-pushed the nftables branch 2 times, most recently from 4b945e2 to a661ebb Compare May 15, 2025 19:00
@robmry robmry force-pushed the nftables branch 8 times, most recently from 3ab54b1 to 110aa76 Compare June 16, 2025 13:40
@robmry robmry force-pushed the nftables branch 4 times, most recently from 0462576 to 496c108 Compare June 17, 2025 19:25
@robmry robmry force-pushed the nftables branch 4 times, most recently from 11bb82a to 558c534 Compare June 18, 2025 17:58
@robmry robmry force-pushed the nftables branch 3 times, most recently from 840d405 to 04d6a1d Compare July 2, 2025 17:30
@robmry robmry force-pushed the nftables branch 10 times, most recently from 4222321 to 3207295 Compare July 15, 2025 08:22
@robmry robmry force-pushed the nftables branch 2 times, most recently from 176ebf3 to 97caa67 Compare July 15, 2025 17:44
robmry added 2 commits July 22, 2025 15:17
Make base chain priorities in the bridge's nftables tables
configurable.

For example, in daemon.json:

        "bridge-nftables-priorities": {
                "filter-FORWARD": "3",
                "nat-POSTROUTING": "101",
                "nat-PREROUTING": "-101",
                "nat-OUTPUT": "-102",
                "raw-PREROUTING": "-301"
        },

Or, on the command line:

    dockerd --bridge-nftables-priority filter-FORWARD=3 ...

Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Add nftables.Modifier, to hold a queue of commands that can be applied
using Modifier.Apply. No updates are made to the underlying Table
until Apply is called, errors in the queue if commands are deferred
until Apply.

This has the advantages that:
- less error handling is needed in code that generates update commands
- it's transactional, without needing explicit transactions

Minor disadvantages are that it's slightly more difficult to debug updates,
as it's no longer possible to step through the call making an update to
the Table manipulation in a debugger - and errors in the command, and
errors like trying to update a nonexistent chain/set/vmap, deleting an
object that doesn't exist or creating a duplicate are not reported
until the updates are applied (so, it's a little less clear where
the update came from).

Signed-off-by: Rob Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants