chore: Small changes #128
Merged
chore: Small changes #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Porting small changes from #100 Signed-off-by: mr.Shu <[email protected]>
Contributor
Author
|
If this is merged, we might want to close #100 |
Contributor
Author
|
It would be great to get this merged in before we merge in #117 |
Adman
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your change in one or two sentences
There were small changes in #100 which were never implemented. This Commit tries to make sure they do get implemented.
Please explain why do you think this change should be in the rules
It would be great if we manage to close #100 at some point