Skip to content

Conversation

@isaeldoori
Copy link
Contributor

Please describe your change in one or two sentences

Your description here

Please explain why do you think this change should be in the rules

Your explanation here

@isaeldoori isaeldoori requested a review from dbscoach June 14, 2025 22:01
* Make sure the runner actually exists.

Signed-off-by: mr.Shu <[email protected]>
scoring.adoc Outdated
presentation or design document. No more than one question from each category should be asked.

General: +
● Which of your design decisions are influenced by which testing/experience? +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isaeldoori @dbscoach would you be open to making these an "Unordered list" by any chance? That should make it render a bit better.

https://docs.asciidoctor.org/asciidoc/latest/lists/unordered/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did, thanks! Other than this change, I think we need to merge now, the PDF version is "as good" as it could be at the moment. We could choose not to share the PDF but only the HTML, which reads 1000 times better. @dbscoach @mrshu @willplum Shall we just merge?

@mrshu
Copy link
Contributor

mrshu commented Jul 9, 2025

@isaeldoori how would this be for a comparison? Would it be better in any way?

https://robocup-junior.github.io/soccer-rules/mrshu/fix-scoring-rubric/scoring.pdf

@isaeldoori
Copy link
Contributor Author

isaeldoori commented Jul 9, 2025

@isaeldoori how would this be for a comparison? Would it be better in any way?

https://robocup-junior.github.io/soccer-rules/mrshu/fix-scoring-rubric/scoring.pdf

That looks better, thanks! Only problem if you look at “Rule 1.2.A.4” and “Rule 1.2.A.6” for example, these should actually be sub sub sections. Not only these 2, many more as well. Can you take a look at that too?

@mrshu
Copy link
Contributor

mrshu commented Jul 9, 2025

So the trouble is that it is just a paragraph when it ends up being a TeX document. That is, the second-lowest sub-section (https://www.overleaf.com/learn/latex/Sections_and_chapters):
image

Could we perhaps bump it a level? That should help I think

@isaeldoori
Copy link
Contributor Author

So the trouble is that it is just a paragraph when it ends up being a TeX document. That is, the second-lowest sub-section (https://www.overleaf.com/learn/latex/Sections_and_chapters): image

Could we perhaps bump it a level? That should help I think

We can try to bump it a level, but then I’m afraid to mess up the HTML where at the moment it’s working

@mrshu
Copy link
Contributor

mrshu commented Jul 9, 2025

Well, it is a h4 (https://robocup-junior.github.io/soccer-rules/mrshu/fix-scoring-rubric/scoring.html#community-award) but if you feel like that's how it should be, I'll try to at least embolden the \paragraph in here :)

@isaeldoori
Copy link
Contributor Author

Well, it is a h4 (https://robocup-junior.github.io/soccer-rules/mrshu/fix-scoring-rubric/scoring.html#community-award) but if you feel like that's how it should be, I'll try to at least embolden the \paragraph in here :)

That sounds like a plan, thanks Marek!

@mrshu
Copy link
Contributor

mrshu commented Jul 9, 2025

@dbscoach dbscoach mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants