In Model.export(), remove the shape arg and the requirement for the shape to be divisible by 14.#400
Open
Abdul-Mukit wants to merge 1 commit intoroboflow:developfrom
Conversation
… call. Remove shape arg from Model.export call.
Contributor
Author
|
I have read the CLA Document and I sign the CLA. |
60b16c1 to
523f9df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #396
In main.py, the Model.export() has the argument
shape. Developers often try to use it and find it broken. This makes the export process confusing. See: #396 and #99 (comment)The clean solution is to define resolution during model initialization. Then just call model.export(). Furthermore, the requirement for the input shape to be divisible by 14 is outdated. See: #396 (comment)
All this makes the
shapeargument inModel.export()call redundant and confusing.This MR simply proposes to remove this argument and the requirement that the shape be divisible by 14 from the Model.export() call.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tried these and both worked: