Fix inverted probability logic in RandomExpand.__call__#476
Open
pantment wants to merge 1 commit intoroboflow:developfrom
Open
Fix inverted probability logic in RandomExpand.__call__#476pantment wants to merge 1 commit intoroboflow:developfrom
pantment wants to merge 1 commit intoroboflow:developfrom
Conversation
pantment
requested review from
Matvezy,
SkalskiP,
isaacrob-roboflow and
probicheaux
as code owners
|
|
pantment
force-pushed
the
fix/random-expand-prob
branch
from
3941392 to
673e41d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the RandomExpand transform where the probability check was inverted, causing the transform to expand images with probability 1 - prob instead of the intended prob as documented in the docstring.
Changes:
- Corrected the probability condition in
RandomExpand.__call__from< self.probto>= self.probfor the early return
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Borda
force-pushed
the
develop
branch
4 times, most recently
from
60b16c1 to
523f9df
Compare
Member
|
@pantment, it seems I cannot resolve the collision for you... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in RandomExpand.call where the probability check was inverted.
According to the docstring, prob is the probability to expand, but the previous implementation expanded with probability 1 - prob.
The condition has been corrected so that expansion now happens with the intended probability.