Add arg is_deprecated to RFDETRLarge class#621
Draft
PierreMarieCurie wants to merge 1 commit intoroboflow:developfrom
Draft
Add arg is_deprecated to RFDETRLarge class#621PierreMarieCurie wants to merge 1 commit intoroboflow:developfrom
is_deprecated to RFDETRLarge class#621PierreMarieCurie wants to merge 1 commit intoroboflow:developfrom
Conversation
Contributor
Author
|
I have read the CLA Document and I sign the CLA. |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0%) is below the target coverage (95%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #621 +/- ##
======================================
Coverage 22% 22%
======================================
Files 46 46
Lines 6182 6182
======================================
Hits 1343 1343
Misses 4839 4839 🚀 New features to boost your workflow:
|
Member
I feel like this adds more confusion there, helping... can you pls elaborate more on the user experience? |
60b16c1 to
523f9df
Compare
is_deprecated to RFDETRLarge class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hello Roboflow team, this PR exposes the is_deprecated parameter of
RFDETRLargeclass so that we can access to the deprecated version of RFDETR-large. I am not able to tell if the non-exposure was intentional, so if it was, feel free to reject this PR.Related Issue(s):
No related issue.
Type of Change
Testing
This script above, with the current
developbranch, loads the new version of RFDETR-large twice (rf-detr-large-2026.pth). The only way to load the old version (rf-detr-large.pth) is to use theRFDETRLargeDeprecatedclass or if loading the new version from theRFDETRLargeclass fails. With my commit, we can access the deprecated version from theRFDETRLargeclass.Checklist