Skip to content

Refactor asserts part 2#2319

Draft
vikassaini77 wants to merge 26 commits into
roboflow:developfrom
vikassaini77:refactor-asserts-part-2
Draft

Refactor asserts part 2#2319
vikassaini77 wants to merge 26 commits into
roboflow:developfrom
vikassaini77:refactor-asserts-part-2

Conversation

@vikassaini77

Copy link
Copy Markdown
Contributor
Before submitting
  • Self-reviewed the code
  • Updated documentation, follow Google-style
  • Added docs entry for autogeneration (if new functions/classes)
  • Added/updated tests
  • All tests pass locally

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🧪 Test update
  • 🔨 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🔧 Chore (dependencies, configs, etc.)

Motivation and Context

Closes #(issue)

Changes Made

Testing

  • I have tested this code locally
  • I have added unit tests that prove my fix is effective or that my feature works
  • All new and existing tests pass

Google Colab (optional)

Colab link:

Screenshots/Videos (optional)

Additional Notes

@vikassaini77 vikassaini77 requested a review from SkalskiP as a code owner June 14, 2026 10:55
@CLAassistant

CLAassistant commented Jun 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Borda Borda marked this pull request as draft June 14, 2026 23:01
@Borda

Borda commented Jun 14, 2026

Copy link
Copy Markdown
Member

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@vikassaini77 pls sign. All your PRs have missed this, and without that we simply cannot merge it regardless of the quality and impact... 🦝

@vikassaini77 vikassaini77 marked this pull request as ready for review June 16, 2026 09:35
@Borda Borda marked this pull request as draft June 16, 2026 19:11
@Borda

Borda commented Jun 18, 2026

Copy link
Copy Markdown
Member

@vikassaini77 pls follow the contribution guidelines. In particular, it means you shall write PR description why it does and how it fixes or improves this package, then you have to sign the CLA (or provide a screenshot of what you did), otherwise, we cannot move forward, even I see based on your changes a value in your contribution 🦝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants