Skip to content

fix: include review context when custom fix instructions are provided#395

Merged
wesm merged 2 commits intoroborev-dev:mainfrom
mariusvniekerk:address-httpsgithub.comroborev
Feb 28, 2026
Merged

fix: include review context when custom fix instructions are provided#395
wesm merged 2 commits intoroborev-dev:mainfrom
mariusvniekerk:address-httpsgithub.comroborev

Conversation

@mariusvniekerk
Copy link
Collaborator

Summary

  • When a user provides custom instructions via Shift+F in the TUI fix modal, the custom prompt was completely replacing the review context instead of being appended to it
  • The fix agent received only the user's short instructions with no knowledge of what the review actually found, causing it to search aimlessly and eventually give up
  • Custom instructions are now combined with the review findings via buildFixPromptWithInstructions, so the agent sees both the original review output and the user's additional guidance

Closes #387

Test plan

  • New test: "custom prompt includes review context" verifies stored prompt contains both review output and custom instructions
  • All 3521 existing tests pass
  • Manual: Shift+F on a review, enter custom instructions, verify agent log shows review findings in the prompt

🤖 Generated with Claude Code

…roborev-dev#387)

When a user provided custom instructions via Shift+F in the TUI, the
custom prompt completely replaced the review context instead of being
appended to it. The fix agent received only the user's instructions
with no knowledge of what the review found, causing it to fail.

Now custom instructions are combined with the review findings using
buildFixPromptWithInstructions, so the agent sees both.

Closes roborev-dev#387

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@roborev-ci
Copy link

roborev-ci bot commented Feb 28, 2026

roborev: Combined Review (85f3789)

Summary Verdict: The code changes introduce a potential behavioral regression regarding how conflicting job inputs are handled, while no security vulnerabilities were
found.

Medium

Regression/Behavior Change

  • File: internal/daemon/server.go (in handleFixJob)
  • Details: The condition changed from
    if fixPrompt == "" && req.StaleJobID > 0 to if req.StaleJobID > 0. This means if both StaleJobID and Prompt are sent, Prompt is now silently ignored.
  • Suggested Fix: Make this explicit in API behavior by
    either:
    1. Rejecting StaleJobID + Prompt with a 400 and a clear error, or
    2. Incorporating Prompt into the rebase prompt path.

Synthesized from 4 reviews (agents: codex, gemini | types: default, security)

…ithInstructions

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@roborev-ci
Copy link

roborev-ci bot commented Feb 28, 2026

roborev: Combined Review (522c440)

Verdict: All agents reviewed the changes and found no issues of medium, high, or critical severity.


Synthesized from 4 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit f0fef72 into roborev-dev:main Feb 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shift F fix in TUI loses the review context if you give custom instructions

2 participants