Skip to content

fix(lint): mark new outbound_api strings as translatable=false #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robster7674 merged 2 commits into from
Jun 8, 2026
Merged

fix(lint): mark new outbound_api strings as translatable=false #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb84650
fix(lint): mark new outbound_api strings as translatable=false to res…
Jun 8, 2026
3b83b3b
chore: trigger greptile re-review
Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Common/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,16 +2004,16 @@ Pressing OK will generate a connection on this phone and display a QR code that
<string name="outbound_api_trigger_summary_low">At or below %1$s %2$s</string>
<string name="outbound_api_trigger_summary_high">At or above %1$s %2$s</string>
<string name="outbound_api_trigger_summary_range">At or below %1$s or at or above %2$s %3$s</string>
<string name="outbound_api_bubble_title">Telegram bubble</string>
<string name="outbound_api_bubble_refresh_title">Refresh in place</string>
<string name="outbound_api_bubble_refresh_desc">Within the refresh window, edit the same bubble instead of posting a new one.</string>
<string name="outbound_api_bubble_refresh_window">Refresh window (minutes)</string>
<string name="outbound_api_bubble_suppress_title">Skip if value unchanged</string>
<string name="outbound_api_bubble_suppress_desc">Don\'t edit the bubble if the new reading is within 1 mg/dL of the last.</string>
<string name="outbound_api_bubble_stale_title">Show "Missed reading." when silent</string>
<string name="outbound_api_bubble_stale_desc">Edit the bubble to a stale or missed state if no new reading arrives in time.</string>
<string name="outbound_api_bubble_stale_threshold">Stale threshold (minutes)</string>
<string name="outbound_api_bubble_missed_threshold">Missed threshold (minutes)</string>
<string name="outbound_api_bubble_title" translatable="false">Telegram bubble</string>
<string name="outbound_api_bubble_refresh_title" translatable="false">Refresh in place</string>
<string name="outbound_api_bubble_refresh_desc" translatable="false">Within the refresh window, edit the same bubble instead of posting a new one.</string>
<string name="outbound_api_bubble_refresh_window" translatable="false">Refresh window (minutes)</string>
<string name="outbound_api_bubble_suppress_title" translatable="false">Skip if value unchanged</string>
<string name="outbound_api_bubble_suppress_desc" translatable="false">Don\'t edit the bubble if the new reading is within 1 mg/dL of the last.</string>
<string name="outbound_api_bubble_stale_title" translatable="false">Show "Missed reading." when silent</string>
<string name="outbound_api_bubble_stale_desc" translatable="false">Edit the bubble to a stale or missed state if no new reading arrives in time.</string>
<string name="outbound_api_bubble_stale_threshold" translatable="false">Stale threshold (minutes)</string>
<string name="outbound_api_bubble_missed_threshold" translatable="false">Missed threshold (minutes)</string>
Comment on lines +2007 to +2016

@greptile-apps greptile-apps Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 translatable="false" permanently removes these strings from the translation pipeline

This approach silences the MissingTranslation lint check by declaring the strings will never be translated, but these are user-visible UI labels ("Refresh in place", "Skip if value unchanged", "Stale threshold (minutes)", etc.) for an app that actively supports 13 locales (de, fr, ru, zh, and 9 more). Marking them non-translatable means Android's extraction tooling will skip them permanently, so translator submissions for these fields will never appear in locale builds. Neighboring strings with the same purpose — outbound_api_preset_custom_json_desc, outbound_api_preset_telegram_desc, outbound_api_send_test — all carry translations in the German file today.

The correct path is to add the translations to each values-*/strings.xml file. If translations are not yet ready, use tools:ignore="MissingTranslation" as a temporary suppression instead — it quiets the lint check without removing the strings from future extraction.

<string name="outbound_api_send_test">Send test message</string>
<string name="outbound_api_test_queued">Test message queued</string>
<string name="outbound_api_no_current_reading">No current reading available</string>
Expand Down Expand Up @@ -2043,10 +2043,10 @@ Pressing OK will generate a connection on this phone and display a QR code that
<string name="api_source_status_no_readings">No API readings yet</string>
<string name="api_source_status_sync_failed">API source sync failed</string>
<string name="outbound_api_preset_sheet_title">Choose destination preset</string>
<string name="outbound_api_preset_glucodroid_cloud">glucodroid.cloud</string>
<string name="outbound_api_preset_glucodroid_cloud_desc">Stream readings to your glucodroid.cloud account.</string>
<string name="outbound_api_glucodroid_subdomain">Subdomain</string>
<string name="outbound_api_glucodroid_ingest_token">Ingest token</string>
<string name="outbound_api_preset_glucodroid_cloud" translatable="false">glucodroid.cloud</string>
<string name="outbound_api_preset_glucodroid_cloud_desc" translatable="false">Stream readings to your glucodroid.cloud account.</string>
<string name="outbound_api_glucodroid_subdomain" translatable="false">Subdomain</string>
<string name="outbound_api_glucodroid_ingest_token" translatable="false">Ingest token</string>
Comment on lines +2047 to +2049

@greptile-apps greptile-apps Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Generic UI terms marked non-translatable alongside brand name

outbound_api_preset_glucodroid_cloud ("glucodroid.cloud") is a brand/domain name and is reasonable to keep untranslated. However, outbound_api_glucodroid_subdomain ("Subdomain") and outbound_api_glucodroid_ingest_token ("Ingest token") are generic technical labels that translators would normally render in the target language. Bundling them with the brand-name string under translatable="false" means they'll always appear in English regardless of locale.

<string name="outbound_api_preset_custom_json_desc">POST normalized glucose JSON to any endpoint.</string>
<string name="outbound_api_preset_telegram_desc">Send text with the Telegram Bot API. The URL can point to a relay.</string>
<string name="outbound_api_preset_gluco_watch_vk_desc">Send compact GV text through VK community messages.</string>
Expand Down
Loading