Skip to content

clean resources when anything after execution raises#256

Merged
reynir merged 1 commit intomainfrom
clean-resources
Jan 26, 2026
Merged

clean resources when anything after execution raises#256
reynir merged 1 commit intomainfrom
clean-resources

Conversation

@hannesm
Copy link
Collaborator

@hannesm hannesm commented Jan 22, 2026

fix #255

Earlier, exceptions were raised. Now, this error can be handled programmatically
fix #255
@hannesm
Copy link
Collaborator Author

hannesm commented Jan 22, 2026

I force-pushed a different solution, and removed the exceptions from Vmm_resources.insert_unikernel. This way if the success branch of the create continuation fails, the fail continuation is called, which cleans up resources.

Copy link
Contributor

@reynir reynir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@reynir reynir merged commit 5d9d5c6 into main Jan 26, 2026
12 checks passed
@reynir reynir deleted the clean-resources branch January 26, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

if there's an error between Vmm_unix.prepare and Vmm_unix.exec, resources are not (always) cleaned up

2 participants