Skip to content

Initial email notifications#199

Draft
PizieDust wants to merge 10 commits intomainfrom
email_notifs
Draft

Initial email notifications#199
PizieDust wants to merge 10 commits intomainfrom
email_notifs

Conversation

@PizieDust
Copy link
Collaborator

Update mollymawk to be able to send welcome emails and verification emails.

@PizieDust PizieDust changed the title Email notifations Initial email notifications Dec 28, 2025
@PizieDust PizieDust requested a review from hannesm December 28, 2025 18:34
@hannesm
Copy link
Contributor

hannesm commented Dec 29, 2025

Thanks for implementing this feature. Would you mind to explain what the semantics of emails should be?

  • some verification email is sent with a unique token (uuid) to verify the email address used for account setup?
  • is this the welcome mail, or is the welcome mail a different one?
  • what is the story about the resending that you implement here? who should be able to trigger a resend (and when)? is this a spam/dos possibility (since anyone can create an account using any email address, and it looks like even without email verification there's the possibility to "resend verification mail"?) or are only admins allowed to trigger a "resend pending verification mails"?
  • what is the failure semantics, so if the sending of an email fails, is it retried?
  • what is the connection semantics? if there are 200 accounts created, are there immediately 200 connections to the mail server established to send out mails, or is there a "process" that ensures there's a single connection (or 2 or 5) to the mail server, and mails are sent sequentially?
  • is a mails sent to admin when an account is created (so that the admin can activate that account)?

@PizieDust PizieDust marked this pull request as draft January 12, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants