Conversation
albatross_json.ml
Outdated
| try Ok (List.map (function `Int i -> i | _ -> failwith "not int") l) | ||
| with Failure e -> Error (`Msg ("cpuids must be int list: " ^ e)) | ||
| in | ||
| Ok (Vmm_core.IS.of_list ids) |
There was a problem hiding this comment.
if it is the empty list/set, this should error
There was a problem hiding this comment.
If we enforce that the list cannot be empty we may have an issue with mollymawk starting, given that whenever we update a unikernel, we save the configuration of this update to the users profile so that we can do a rollback. This config will always error our as it doesnt have a "cpuids" in its json, and since it can't be empty, mollymawk fails to start.
There was a problem hiding this comment.
perhaps we need mollymawk to wipe all update logs after the rollback period has expired. then this problem goes away.
| startup = info.startup; | ||
| fail_behaviour = info.fail_behaviour; | ||
| cpuid = info.cpuid; | ||
| memory = info.cpuid; |
There was a problem hiding this comment.
that's a bugfix (that memory used to be the cpuid) which deserves a separate PR.
2 participants
This PR adds support in mollymawk for other vm types.
The supporting albatross PR is: robur-coop/albatross#250