allow unexpected_cfgs in RustGlue.roc#10228
Open
Giesch wants to merge 1 commit into
Open
Conversation
* this prevents a spurious lint in rust platforms including rust std; `#[cfg(not(no_roc_std_helpers))]` becomes an unrecognized cfg
Giesch
force-pushed
the
giesch/allow-unexpected-cfg-in-rust-glue
branch
from
July 19, 2026 19:07
d530f7c to
9db13e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny quality of life change for the rust platform template. If you're writing a non-no-std rust platform (ie, using the rust standard library), and you generate code with
RustGlue.roc, the generated code trips a warning for an unrecognizedcfgofno_roc_std_helpers. But, this is expected in that case.This change is to specifically allow unrecognized cfgs in the generated file. There may be a better solution I haven't thought of.