feat: implement flag to suppress defaults warnings#222
Merged
0xcadams merged 4 commits intorocicorp:mainfrom Jan 7, 2026
Merged
feat: implement flag to suppress defaults warnings#2220xcadams merged 4 commits intorocicorp:mainfrom
0xcadams merged 4 commits intorocicorp:mainfrom
Conversation
selfire1
changed the title
rhbuckley
pushed a commit
to rhbuckley/drizzle-zero
that referenced
this pull request
Feb 15, 2026
* fix: remove warn logs for defaults * Revert "fix: remove warn logs for defaults" This reverts commit 901b09f. * chore: implement suppress warnings tests * feat: implement `suppressDefaultsWarning` flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per @aboodman's suggestion:
Happy to rework the warning instead of removing it, if needed. Also happy for you to close this PR and tweak the warning if that's better.
I didn't write a test, since we're not testing for logging in the test currently and it's a straightforward change. From what I can see this change doesn't set any tests to failing that passed previously.
Related: #197