fix: make sure 'bundle install' is always called during updates #420
Conversation
|
@doudou I'm also intrigued by run_package_managers_without_packages. As far as I can see, resolve_and_partition_osdep_packages will never return an empty list unless the manager explicitly requires it (by implementing Manager#call_while_empty?), in which case |
g-arjones
force-pushed
the
always_call_bundler_manager_install
branch
from
0301754 to
92e8a32
Compare
|
@doudou Ping |
| options = [] | ||
| binstubs_path = File.join(root_dir, "bin") | ||
| if updated || !install_only || !File.file?("#{gemfile_path}.lock") | ||
| if updated || !File.file?("#{gemfile_path}.lock") |
There was a problem hiding this comment.
I don't understand this one
"install_only" means "do not update". We are already checking if the gemfile got updated and run unconditionally, I don't understand why !install_only was removed.
There was a problem hiding this comment.
Hmm... I'm gonna have to go back to it. It's been a while (should have put a comment)
| def install( | ||
| osdep_packages, all: nil, install_only: false, | ||
| run_package_managers_without_packages: false, **options | ||
| run_package_managers_without_packages: true, **options |
There was a problem hiding this comment.
I agree. It feels like this is duplicated with the call_while_empty? flag. I'm guessing it was two attempts at fixing the same issue.
There was a problem hiding this comment.
Wanna remove it or keep it for backwards compatibility (although this is a "very" private API...)?
To ensure that a lock file always exists and is up-to-date in the prefix,
BundlerManager#installmust be called during all update operations.Fixes #419