fix: drop --path and similar from bundler invocations #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@chhtz maybe you already have tested this locally, so you have an easy way to find if this works? |
pierrewillenbrockdfki
force-pushed
the
bundler-4
branch
2 times, most recently
from
a350696 to
8441e07
Compare
chhtz
reviewed
Dec 4, 2025
pierrewillenbrockdfki
force-pushed
the
bundler-4
branch
from
8441e07 to
9560286
Compare
chhtz
reviewed
Dec 4, 2025
Member
|
To me it looks good. I have no idea about the failed unit tests though, nor whether some changes are actually redundant. Maybe @doudou or @g-arjones can weigh in. |
Contributor
Author
|
The unit test might need #421 to work again, but i am not sure if that is all. |
Newer rexml versions started rejecting empty files as invalid XML
Member
|
Just extracted the "fix CI" commits from the other PR #426 |
Of note here is the different meaning of --path between bundle install and bundle binstubs, where the former uses the configuration entry "path", while the later uses "bin", which they are saying in their documentation but are not clear that those refer to the configuration variables.
instead, set the configuration option before and call bundle binstubs --all afterwards.
Member
|
FYI ... just rebased your PR on top of the |
doudou
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of note here is the different meaning of --path between bundle install and bundle binstubs, where the former uses the configuration entry "path", while the later uses "bin", which they are saying in their documentation but are not clear that those refer to the configuration variables.