PTBC1: Diyana Ramlan #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| board[i].push(''); | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
good work setting a board of variable size!
Comment on lines
+109
to
+122
| const plusButtonClick = (target) => { | ||
| const currentValue = Number(target.value); | ||
| target.value = currentValue + 1; | ||
| buildEmptyBoard(target.value); | ||
| buildBoard(board); | ||
| }; | ||
|
|
||
| const minusButtonClick = (target) => { | ||
| const currentValue = Number(target.value); | ||
| if (currentValue >= 4) { | ||
| target.value = currentValue - 1; } | ||
| buildEmptyBoard(target.value); | ||
| buildBoard(board); | ||
| }; |
There was a problem hiding this comment.
awesome work getting the board to resize when the user clicks the + - buttons!
| // create the board container element and put it on the screen | ||
| const initGame = () => { | ||
| // append message Container with defaulty message | ||
| output('Win by plotting your Xs or Os in a<br>diagonal, horizontal or vertical manner'); |
There was a problem hiding this comment.
consider making a variable for default message to avoid repetition:
const defaultMsg = 'Win by plotting your Xs or Os in a<br>diagonal, horizontal or vertical manner';
output(defaultMsg);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
3 hours
Please fill in one error and/or error message you received while working on this assignment.
i couldn't get the diagonal win check to work for some reason but i finally realised by variable kept resetting itself in the current placement and had to move it out of the loop
What part of the assignment did you spend the most time on?
the diagonal check
Comfort Level (1-5):
5
Completeness Level (1-5):
3 - will complete more comfortable if i had more time. weekends are a bit difficult.
What did you think of this deliverable?
nice!
Is there anything in this code that you feel pleased about?
:)