Skip to content

PTBC1 -zaver tan feng #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tanfeng95
Copy link

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?

2hrs

Please fill in one error and/or error message you received while working on this assignment.

the win condition error is not working

What part of the assignment did you spend the most time on?

win condition

Comfort Level (1-5):

4

Completeness Level (1-5):

3

What did you think of this deliverable?

NIL

Is there anything in this code that you feel pleased about?

NIL

Copy link

@michelle-mok michelle-mok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well organised code.
consider adding comments so that it's easier for the reader to follow what your code is doing
keep up the good work!

let winChoice = document.querySelector('.winSize').value;
winChoice = parseInt(winChoice, 10);
console.log(`winChoice = ${winChoice}`);
board = Array(Arraynum).fill(Array(Arraynum).fill(' '));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a space between the inverted commas at the end of this line, which is making the condition in line 115 false. that's why nothing is showing when the squares are clicked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants