feat: highlight factory expand icon when inputs are under-supplied#135
Open
the-real-oliverf wants to merge 1 commit into
Open
feat: highlight factory expand icon when inputs are under-supplied#135the-real-oliverf wants to merge 1 commit into
the-real-oliverf wants to merge 1 commit into
Conversation
The expand/collapse icon next to a factory's name on /factories now turns red with a red outline when any of its inputs is short on supply, matching the existing 'Missing X' indicator on input rows. The shared calculation lives in computeOutputUsage so the row-level and factory-level signals stay in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expand/collapse icon next to a factory's name on /factories now turns red with a red outline when any of its inputs is short on supply, matching the existing 'Missing X' indicator on input rows. The shared calculation lives in computeOutputUsage so the row-level and factory-level signals stay in sync.
This means you can tell which factories are under-supplied even if the inputs list is collapsed.
Note that this was mainly generated by AI because I'm not familiar with the project or libraries used. But I've read all the code and it seems totally reasonable to me (I'm a software engineer). I assume you don't object to AI code since you have {CLAUDE|AGENTS}.md files in the project.