Skip to content

fix: move build info footer#25

Merged
tylerdave merged 8 commits into
mainfrom
footer-format
Mar 1, 2026
Merged

fix: move build info footer#25
tylerdave merged 8 commits into
mainfrom
footer-format

Conversation

@tylerdave
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2026

Docs Site preview: https://b496f40e.rockgarden.pages.dev

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

@tylerdave tylerdave merged commit ee9ceb5 into main Mar 1, 2026
2 checks passed
@tylerdave tylerdave deleted the footer-format branch March 1, 2026 05:56
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously flagged footer placement bug is now fixed. Moving {% block footer %} inside the max-w-4xl mx-auto div correctly constrains the footer and its border-t separator to the content width. Good call.

One concern with the strip_content_title change in builder.py — see inline comment.


if page.frontmatter.get("title"):
content = strip_content_title(content)
content = strip_content_title(content)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: strip_content_title is now called unconditionally for all pages, including those with no frontmatter title. For a page like analysis.md starting with # Introduction (a section heading, not the document title), that heading will be silently stripped while the template's {% block heading %} separately renders <h1>analysis</h1> from the filename. The existing tests only cover the case where the leading H1 matches the derived title (my-page.md + # My Page). Previously the guard if page.frontmatter.get("title") ensured stripping only happened when the template title and content H1 were guaranteed to be the same heading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant