feat: switch to pydantic for modeling#26
Merged
Merged
Conversation
Member
tylerdave
commented
Mar 1, 2026
tylerdave
commented
- Switch to pydantic for modeling
- Update collections plans for future work
Contributor
|
Docs Site preview: https://39fa1ea0.rockgarden.pages.dev |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM - the dataclass → Pydantic migration is clean and correct. model_validate handles all the field coercions that were previously done manually in from_dict: Path fields are auto-coerced from strings, nested sub-models are resolved automatically, and the base_url stripping is properly moved into a field_validator. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.