Conversation
Contributor
|
Docs Site preview: https://a1969b68.rockgarden.pages.dev |
There was a problem hiding this comment.
LGTM — all three previously flagged bugs are resolved:
-
og:urlconstruction — the template now correctly handlesindexslugs (strippingindexand using trailing slash) andclean_urls=False(appending.html), matching the logic inget_url(). Thebase_urlvalidator already strips trailing slashes, so no double-slash risk. -
keywordsas YAML list —{% if _kw is string %}...{% elif _kw %}...{% endif %}correctly handles both string and list values. -
Folder index pages — the
{% elif folder is defined %}branch now populates_title,_slug, and_fmfromFolderIndex, which has a.frontmatterdict field confirmed innav/folder_index.py:34.
No new issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.