fix: implement tag index pages#28
Merged
Merged
Conversation
Contributor
|
Docs Site preview: https://50752070.rockgarden.pages.dev |
There was a problem hiding this comment.
All four previously-flagged bugs are resolved in this PR:
- Path traversal — fixed by moving
normalize_tagintourls.pywith a regex that strips everything outside[a-z0-9_-], including/and.. clean_urls=Falsesilently ignored for tag pages — fixed;build_tag_pagesnow writestags/<slug>.htmlwhenclean_urls=False, andget_tag_urlgenerates matching URLs.- & 4. Tag slug mismatch in templates — fixed by exposing
normalize_tagas a Jinja2 global inengine.pyand using{% set tag_slug = normalize_tag(tag) %}in bothpage.htmlandfolder_index.html.
LGTM — no new significant issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.