Skip to content

fix: implement tag index pages#28

Merged
tylerdave merged 3 commits into
mainfrom
tag-index-pages
Mar 1, 2026
Merged

fix: implement tag index pages#28
tylerdave merged 3 commits into
mainfrom
tag-index-pages

Conversation

@tylerdave
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2026

Docs Site preview: https://50752070.rockgarden.pages.dev

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All four previously-flagged bugs are resolved in this PR:

  1. Path traversal — fixed by moving normalize_tag into urls.py with a regex that strips everything outside [a-z0-9_-], including / and ..
  2. clean_urls=False silently ignored for tag pages — fixed; build_tag_pages now writes tags/<slug>.html when clean_urls=False, and get_tag_url generates matching URLs.
  3. & 4. Tag slug mismatch in templates — fixed by exposing normalize_tag as a Jinja2 global in engine.py and using {% set tag_slug = normalize_tag(tag) %} in both page.html and folder_index.html.

LGTM — no new significant issues found.

@tylerdave tylerdave merged commit caae8cc into main Mar 1, 2026
3 checks passed
@tylerdave tylerdave deleted the tag-index-pages branch March 1, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant