fix: add configurability to search stop words#99
Conversation
|
Docs Site preview: https://7896a674.rockgarden.pages.dev |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
The CDN auto-detection and search stopwords features look well-implemented. The incremental build consistency bug (previous issue #2) is now properly fixed by including cdn_flags in the manifest. One previously-flagged regex issue at line 436 remains.
| # Resolve CDN auto-detection by scanning raw content | ||
| math_cdn = config.theme.math_cdn | ||
| if math_cdn == "auto": | ||
| _math_re = re.compile(r"\$\$|```math|\$[^\s\d$]") |
There was a problem hiding this comment.
Bug: Previously flagged and still present. \$[^\s\d$] still false-positives on shell variable names ($HOME, $PATH) and JS template literals (${x}), which are common in technical docs and will cause KaTeX to load unnecessarily on those pages. A tighter pattern that avoids matching $WORD (uppercase/lowercase identifier-style variables) would be r'\$\$|```math|(?<![\w])\$(?![\s\d\w])' — the (?![\w]) negative lookahead drops $VAR while still catching inline math like $x^2$ when followed by a math expression character.
1 participant
No description provided.