-
Notifications
You must be signed in to change notification settings - Fork 10
code and needles for rocky10u1 #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds needles and code changes to support Rocky Linux 10.1 release testing, including fixes for installation source checking, version-specific workarounds, and support for GenericCloud aarch64 images.
Key Changes:
- Updated version-specific workarounds for Rocky 8 and Rocky 10+ with French language
- Enhanced
_check_install_source.pmto handle multiple Fedora/Rocky version log formats - Added GenericCloud aarch64 product configurations and test profiles
- Added numerous needle files for UI changes across multiple languages (Russian, Japanese, French)
Reviewed changes
Copilot reviewed 72 out of 139 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/disk_guided_encrypted.pm | Restricts keyboard layout workaround to pre-Rocky 9 versions |
| tests/_do_install_and_reboot.pm | Adds workaround to skip user creation verification for French in Rocky 10+ |
| tests/_check_install_source.pm | Updates repository verification to handle F35+/F36+ log format changes |
| templates.fif.json | Adds aarch64 GenericCloud product and profile configurations |
| needles/**/*.json | Adds needle definitions for UI changes in Rocky 10.1 across languages |
| needles/**/*.png | Binary needle image files (not reviewed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlanMarshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
./fifloader.py -c -l templates.fif.json
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-dvd-iso-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-universal-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-boot-iso-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=package-set VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-package-set-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-minimal.iso ARCH=x86_64 DISTRI=rocky FLAVOR=minimal-iso VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-minimal-iso-10.1
openqa-cli api -X POST isos ISO=Rocky-8.10-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.10 CURRREL=8 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-universal-8.10 TEST=install_simple_encrypted
Result:
Compared to previous tests, install_european_language, install_repository_http_graphical and install_repository_http_variation now pass as would be expected from the respective code changes.
Other language tests no longer fail at _check_install_source however a possible remaining issue it that:
install_mirrorlist_graphical fails at _check_install_source with the message: command 'grep "Added the 'anaconda'" /tmp/anaconda.log' failed
properly identify pre-release for Rocky will be tested in the next few weeks when 10.2-LookAhead iso is issued.
I have not tested any of the GenericCloud items added in templates.fif.json
Needles and code for Rocky Linux 10.1 release includes...
desktop_launch_terminalprovided in upstream to be used in future updatesAdditionally...
NOTE: This is a
templates.fif.jsonupdate which can only be verified after runningfif_loader.pyPR Runs in prod...
Sample Runs in dev...