Skip to content

Conversation

@tcooper
Copy link
Member

@tcooper tcooper commented Dec 3, 2025

Needles and code for Rocky Linux 10.1 release includes...

  • fixes for check_install_source
  • update a workaround needed only for rocky8
  • add a workaround for french language in rocky10+
  • properly identify pre-release for Rocky
  • add needles for UI changes
  • add needles for colored output in root console
  • adds utility subroutine, desktop_launch_terminal provided in upstream to be used in future updates

Additionally...

  • add support for GenericCloud image testing for aarch64

NOTE: This is a templates.fif.json update which can only be verified after running fif_loader.py

PR Runs in prod...

Sample Runs in dev...

rocky-9 7-universal-x86_64-Buildtcooper_os-autoinst-distri-rocky_251-install_european_language rocky-10 1-universal-x86_64-Buildtcooper_os-autoinst-distri-rocky_251-install_european_language

@tcooper tcooper self-assigned this Dec 3, 2025
@tcooper tcooper added priority: medium This issue or pull request is of medium priority type: bug Something isn't working type: needles This issue or pull request is for needle changes type: templates.fif.json Improvements or change to templates.fif.json labels Dec 3, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds needles and code changes to support Rocky Linux 10.1 release testing, including fixes for installation source checking, version-specific workarounds, and support for GenericCloud aarch64 images.

Key Changes:

  • Updated version-specific workarounds for Rocky 8 and Rocky 10+ with French language
  • Enhanced _check_install_source.pm to handle multiple Fedora/Rocky version log formats
  • Added GenericCloud aarch64 product configurations and test profiles
  • Added numerous needle files for UI changes across multiple languages (Russian, Japanese, French)

Reviewed changes

Copilot reviewed 72 out of 139 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/disk_guided_encrypted.pm Restricts keyboard layout workaround to pre-Rocky 9 versions
tests/_do_install_and_reboot.pm Adds workaround to skip user creation verification for French in Rocky 10+
tests/_check_install_source.pm Updates repository verification to handle F35+/F36+ log format changes
templates.fif.json Adds aarch64 GenericCloud product and profile configurations
needles/**/*.json Adds needle definitions for UI changes in Rocky 10.1 across languages
needles/**/*.png Binary needle image files (not reviewed)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tcooper tcooper marked this pull request as ready for review December 3, 2025 05:44
Copy link
Contributor

@AlanMarshall AlanMarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

./fifloader.py -c -l templates.fif.json
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-dvd-iso-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-universal-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-boot-iso-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=package-set VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-package-set-10.1
openqa-cli api -X POST isos ISO=Rocky-10.1-x86_64-minimal.iso ARCH=x86_64 DISTRI=rocky FLAVOR=minimal-iso VERSION=10.1 CURRREL=10 DNF_CONTENTDIR=pub/rocky DNF_RELEASEVER=10.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-minimal-iso-10.1
openqa-cli api -X POST isos ISO=Rocky-8.10-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.10 CURRREL=8 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-universal-8.10 TEST=install_simple_encrypted

Result:
Compared to previous tests, install_european_language, install_repository_http_graphical and install_repository_http_variation now pass as would be expected from the respective code changes.

Other language tests no longer fail at _check_install_source however a possible remaining issue it that:
install_mirrorlist_graphical fails at _check_install_source with the message: command 'grep "Added the 'anaconda'" /tmp/anaconda.log' failed

properly identify pre-release for Rocky will be tested in the next few weeks when 10.2-LookAhead iso is issued.

I have not tested any of the GenericCloud items added in templates.fif.json

@AlanMarshall AlanMarshall merged commit 44602fb into rocky-linux:develop Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium This issue or pull request is of medium priority type: bug Something isn't working type: needles This issue or pull request is for needle changes type: templates.fif.json Improvements or change to templates.fif.json

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants