Skip to content

Implement vertical tabs for mobile download page and fix width alignment #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
+14 −6
Closed

Implement vertical tabs for mobile download page and fix width alignment #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38220b2
Initial plan
Copilot Aug 9, 2025
42ac42d
Fix mobile download tabs horizontal scrolling issue
Copilot Aug 9, 2025
41aa618
Implement vertical tabs for mobile instead of horizontal scrolling
Copilot Aug 9, 2025
b09183c
Fix width alignment between header and download page cards
Copilot Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions app/[locale]/download/components/TabsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ const TabsClient = ({ architectures, translations }: TabsClientProps) => {
value={currentArch}
onValueChange={updateArchitecture}
>
{/* Desktop tabs - horizontal */}
<TabsList className="sm:flex justify-center gap-4 hidden">
{Object.keys(architectures).map((arch) => (
<TabsTrigger
Expand All @@ -176,16 +177,23 @@ const TabsClient = ({ architectures, translations }: TabsClientProps) => {
</TabsTrigger>
))}
</TabsList>
<TabsList className="flex justify-center gap-4 sm:hidden">

{/* Mobile tabs - vertical stack */}
<div className="sm:hidden space-y-2">
{Object.keys(architectures).map((arch) => (
<TabsTrigger
<button
key={arch}
value={arch}
onClick={() => updateArchitecture(arch)}
className={`w-full text-left py-3 px-4 rounded-md border transition-colors ${
currentArch === arch
? "bg-primary text-primary-foreground border-primary"
: "bg-background border-border hover:bg-muted"
}`}
>
{translations.tabsShortened[arch]}
</TabsTrigger>
</button>
))}
</TabsList>
</div>
{Object.entries(architectures).map(([arch, data]) => (
<TabsContent
key={arch}
Expand Down
2 changes: 1 addition & 1 deletion app/[locale]/download/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const DownloadPage = () => {
return (
<>
<div className="py-24 sm:py-32">
<div className="mx-auto max-w-7xl px-6 lg:px-8">
<div className="mx-auto max-w-7xl px-2 lg:px-0">
<div className="text-center">
<h2 className="text-3xl font-bold font-display tracking-tight sm:text-4xl">
{t("title")}
Expand Down