Ensure all files have designated maintainers#21549
Ensure all files have designated maintainers#21549yannl35133 wants to merge 1 commit intorocq-prover:masterfrom
Conversation
that doesn't sound right, maybe dev-tools instead |
.github/CODEOWNERS
Outdated
| /.ocamlinit @rocq-prover/build-maintainers | ||
| *dune* @rocq-prover/build-maintainers | ||
| *.opam @rocq-prover/build-maintainers @erikmd | ||
| *.opam.template @rocq-prover/build-maintainers @erikmd |
There was a problem hiding this comment.
if @Zimmi48 agrees, I suggest that you replace erikmd with @Justme0606 here
There was a problem hiding this comment.
FWIW, this mention in the CODEOWNERS was useful for the docker-rocq maintainer(s) to be aware soonish of build changes in rocq master, so that the docker-rocq config can be updated earlier, and not after a docker-rocq:dev rebuild failure
af0d18a to
1c1b104
Compare
1c1b104 to
398e404
Compare
|
For the teams they can make a PR later if there's a problem but I'd like an explicit ok before merging for people explicitly named: @silene and @Justme0606 |
|
Also for @Justme0606 I think he would need to be part of the organization to get review requests and AFAICT he isn't. |
Sure, no problem. I had discussed the continuity of docker-rocq with Erik, so this is fine with me. |
("All files" doesn't include files that shouldn't have a maintainer)
At the end, I only looked for the team I found most suitable, all changes are suggestions and up to discussion.
Proposed changes in decreasing order of justifications (if not mentioned, they were unassigned):
/dev/tools/make_git_revision.shto @rocq-prover/build-maintainers (that appeared to be the case already, but the later assignment of/dev/tools/overrode it)/kernel/pConstraints.*and/kernel/qGraph.*transferred from @rocq-prover/kernel-maintainers to @rocq-prover/universes-maintainers/config/to @rocq-prover/build-maintainers/tools/rocqtex*to @silene (as maintainer of/tools/coq_tex.*)/tools/rocqwc*to @rocq-prover/coqdoc-maintainers (as maintainer of/tools/coqwc*)*.mldto @rocq-prover/doc-maintainers (the commit that added them says they exist for documentation; they might have become useless now)/dev/ml_toplevel/to @rocq-prover/toplevel-maintainers*.opamfrom @rocq-prover/build-maintainers and @erikmd to @rocq-prover/build-maintainers and @Just0606*.opam.templateto @rocq-prover/build-maintainers and @erikmd as maintainers of*.opam/tools/to @rocq-prover/dev-tools-maintainers (as fallback if no other assignment applies)/dev/to @rocq-prover/dev-tools-maintainers (as fallback if no other assignment applies, this should only be files in no subfolder).gitattributes .gitignore .ocp-indentto @rocq-prover/build-maintainers.mailmap CREDITS LICENSEto @rocq-prover/contributing-process-maintainersI will wait for one person accepting on behalf of a team to consider all concerned changes accepted, and I will probably remove from the PR all propositions that aren't accepted after some time (or those outright refused), I don't intend to push them hard.