Skip to content

setoid rewriting: improve support for forall_relation#21560

Open
MathisBD wants to merge 1 commit intorocq-prover:masterfrom
MathisBD:setoid_rewrite_forall
Open

setoid rewriting: improve support for forall_relation#21560
MathisBD wants to merge 1 commit intorocq-prover:masterfrom
MathisBD:setoid_rewrite_forall

Conversation

@MathisBD
Copy link
Contributor

This PR improves the support for forall_relation in setoid rewriting:

  1. Added support for forall_relation in the normalization wrt flip algorithm of setoid rewriting.
  2. Added a notation for forall_relation in scope signature_scope which allows writing instances like Proper (R ==> ∀ x y, S) with x and y appearing in S.

@MathisBD MathisBD requested a review from a team as a code owner January 29, 2026 14:53
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jan 29, 2026
@MathisBD
Copy link
Contributor Author

There seems to be lots of trailing whitespace removed in the diff, someone knows what's going on?

@MathisBD
Copy link
Contributor Author

Ah it seems that Notation "∀ x .. y , R" := ... will not work because it's already used elsewhere. What do you suggest? Not exporting the notation by default, so that users have to do something like Import ProperForallNotation, or using a different notation?

@Lysxia
Copy link
Contributor

Lysxia commented Jan 29, 2026

There seems to be lots of trailing whitespace removed in the diff, someone knows what's going on?

Probably your editor (or git) is configured to auto-delete trailing whitespace and you probably want to disable it.

Ah it seems that Notation "∀ x .. y , R" := ... will not work because it's already used elsewhere.

How about forallR?

@MathisBD
Copy link
Contributor Author

Probably your editor (or git) is configured to auto-delete trailing whitespace and you probably want to disable it.

Yes my editor is doing this. I'm confused now: doesn't Rocq have a policy of no trailing whitespace in source files?

How about forallR?

Why not. What do others think?

@thomas-lamiaux
Copy link
Contributor

thomas-lamiaux commented Jan 29, 2026

The linter is supposed to reject trailing white spaces, I don't know what is up. @SkySkimmer ?

(It might be that the modif are checked not to introduce trailing white spaces but not that the whole project is without 🤷)

Proof.
rewrite <-Hle.
exact H.
Qed. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Qed.
Qed.

@SkySkimmer
Copy link
Contributor

We check that changed lines don't have trailing whitespace but we allow old trailing whitespace to exist

@mattam82
Copy link
Member

Probably your editor (or git) is configured to auto-delete trailing whitespace and you probably want to disable it.

Yes my editor is doing this. I'm confused now: doesn't Rocq have a policy of no trailing whitespace in source files?

It does now, but on existing files we avoid brutally doing it for easier diff reading and blaming.

How about forallR?

Why not. What do others think?

Fine with me

@MathisBD MathisBD force-pushed the setoid_rewrite_forall branch 4 times, most recently from 5b69b4d to aad50d8 Compare February 2, 2026 09:45
@MathisBD MathisBD force-pushed the setoid_rewrite_forall branch from aad50d8 to 39ab00f Compare February 2, 2026 09:47
@mattam82 mattam82 self-assigned this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants