Move rewrite strat asts to ltac1 plugin#21571
Open
SkySkimmer wants to merge 1 commit intorocq-prover:masterfrom
Open
Move rewrite strat asts to ltac1 plugin#21571SkySkimmer wants to merge 1 commit intorocq-prover:masterfrom
SkySkimmer wants to merge 1 commit intorocq-prover:masterfrom
Conversation
SkySkimmer
added
needs: merge of dependency
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added
request: full CI
github-actions
bot
added
the
needs: rebase
SkySkimmer
added a commit
to SkySkimmer/coq-tactician
that referenced
this pull request
Feb 4, 2026
SkySkimmer
force-pushed
the
rew-strar-ast
branch
from
b3aaecc to
e9e6f3a
Compare
coqbot-app
bot
removed
request: full CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends:
matchesandtacticcall strategies for generalized rewriting #21521 (to reduce rebase pain)While talking about #21521, I'm not sure if the
ltac1_tactic_callcould be implemented based ontactic_calland moved to ltac1 plugin. The main (only?) issue ismake_tactic_goalusing APIs internal to rewrite.mlnew_cstr_evarand the sort dependant mk_relation.Overlays: