Typecheck ignoring errors instead of globalize for Ltac2 Globalize#21618
Merged
coqbot-app[bot] merged 1 commit intorocq-prover:masterfrom Feb 27, 2026
Merged
Typecheck ignoring errors instead of globalize for Ltac2 Globalize#21618coqbot-app[bot] merged 1 commit intorocq-prover:masterfrom
coqbot-app[bot] merged 1 commit intorocq-prover:masterfrom
Conversation
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
ppedrot
reviewed
Feb 25, 2026
SkySkimmer
added
the
needs: progress
This adds a mode to ltac2 typechecking which accumulates errors instead of raising an exception at the first error. Ltac2 Globalize then uses this mode and ignores the accumulated errors (we could print them instead). The accumulation mode could also be used to provide all errors from an ltac2 expression in regular code in the future (with a flag). Together with rocq-prover#21617 this gets us closer to removing the globalize code (which doesn't work on quotations so should be avoided).
SkySkimmer
force-pushed
the
noglobalize
branch
from
809a96f to
ca415d1
Compare
SkySkimmer
removed
the
needs: progress
coqbot-app
bot
added
the
needs: full CI
SkySkimmer
removed
the
needs: full CI
ppedrot
approved these changes
Feb 27, 2026
Member
|
@coqbot merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a mode to ltac2 typechecking which accumulates errors instead of raising an exception at the first error.
Ltac2 Globalize then uses this mode and ignores the accumulated errors (we could print them instead).
The accumulation mode could also be used to provide all errors from an ltac2 expression in regular code in the future (with a flag).
Together with #21617 this gets us closer to removing the globalize code (which doesn't work on quotations so should be avoided).