Optimize a fast-path in Genlambda compilation.#21679
Open
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Open
Optimize a fast-path in Genlambda compilation.#21679ppedrot wants to merge 1 commit intorocq-prover:masterfrom
ppedrot wants to merge 1 commit intorocq-prover:masterfrom
Conversation
Rather than computing first whether a variable appears in a term in O(n) and then checking that some term is a value in O(1), we flip the order. This prevents a superlinear blowup in an optimization pass in Genlambda that was observable in rocq-prover#13606.
ppedrot
added
kind: performance
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than computing first whether a variable appears in a term in O(n) and then checking that some term is a value in O(1), we flip the order. This prevents a superlinear blowup in an optimization pass in Genlambda that was observable in #13606.