Skip to content

Process attributes after Qed/Defined#22118

Open
gmalecha-at-skylabs wants to merge 4 commits into
rocq-prover:masterfrom
SkyLabsAI:gmalecha/attributes-on-hooks
Open

Process attributes after Qed/Defined#22118
gmalecha-at-skylabs wants to merge 4 commits into
rocq-prover:masterfrom
SkyLabsAI:gmalecha/attributes-on-hooks

Conversation

@gmalecha-at-skylabs

Copy link
Copy Markdown

This PR extends the handling of attributes so that handlers are executed when the term is completed, e.g. at the Qed or Defined.

It uses this feature to implement a plugin that provides an attribute #[hint(db=...,cost=...,visibility=...)]. This should be either incorporated into core Rocq or introduced as a separate plugin.

For now, I'm just looking for feedback, the commits should be independently reviewable. The last commit contains the hint attribute implementation and could probably use more testing.

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.
  • Opened overlay pull requests.

@coqbot-app coqbot-app Bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 10, 2026
Comment thread vernac/comFixpoint.ml Outdated
@gmalecha-at-skylabs gmalecha-at-skylabs marked this pull request as ready for review June 12, 2026 15:30
@gmalecha-at-skylabs gmalecha-at-skylabs requested a review from a team as a code owner June 12, 2026 15:30
@gmalecha-at-skylabs

Copy link
Copy Markdown
Author

@SkySkimmer What should the next steps here be?

  1. I think it would be really useful to get the core part of the change in so that attributes on Lemma and whatnot work well. The only concern is that you could run into an error on Qed after you do a big proof.
  2. What do you think about the code that actually implements the attribute? Should it be placed in a plugin that is distributed separately?

I'm happy to put more cycles into the development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants