Process attributes after Qed/Defined#22118
Open
gmalecha-at-skylabs wants to merge 4 commits into
Open
Conversation
SkySkimmer
reviewed
Jun 10, 2026
Author
|
@SkySkimmer What should the next steps here be?
I'm happy to put more cycles into the development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the handling of attributes so that handlers are executed when the term is completed, e.g. at the
QedorDefined.It uses this feature to implement a plugin that provides an attribute
#[hint(db=...,cost=...,visibility=...)]. This should be either incorporated into core Rocq or introduced as a separate plugin.For now, I'm just looking for feedback, the commits should be independently reviewable. The last commit contains the hint attribute implementation and could probably use more testing.
make doc_gram_rsts.