Skip to content

split FinFun and Permutation into List and Vector#154

Merged
andres-erbsen merged 3 commits into
rocq-prover:masterfrom
andres-erbsen:split-FinFun
Jun 14, 2025
Merged

split FinFun and Permutation into List and Vector#154
andres-erbsen merged 3 commits into
rocq-prover:masterfrom
andres-erbsen:split-FinFun

Conversation

@andres-erbsen

@andres-erbsen andres-erbsen commented May 31, 2025

Copy link
Copy Markdown
Collaborator

@andres-erbsen andres-erbsen changed the title split FinFun into List and Vector split FinFun and Permutation into List and Vector Jun 1, 2025
@andres-erbsen andres-erbsen force-pushed the split-FinFun branch 2 times, most recently from 3e73c20 to 4bf8fca Compare June 2, 2025 17:41
@andres-erbsen

Copy link
Copy Markdown
Collaborator Author

@proux01 can you help me understand what this CI error means? (I have an overlay that I'd like to test).

building '/nix/store/kazrhh85jndwbaz7ijw3yqd82g2r6m4v-rocq-core9.0-corn-dev.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/2i68d6p7r699zh5s00ddw3841i4f8n2i-source
source root is source
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
no configure script, doing nothing
Running phase: buildPhase
no Makefile or custom buildPhase, doing nothing
Running phase: installPhase
no Makefile or custom installPhase, doing nothing
Running phase: fixupPhase
error: builder for '/nix/store/kazrhh85jndwbaz7ijw3yqd82g2r6m4v-rocq-core9.0-corn-dev.drv' failed to produce output path for output 'out' at '/nix/store/kazrhh85jndwbaz7ijw3yqd82g2r6m4v-rocq-core9.0-corn-dev.drv.chroot/root/nix/store/d1cycii872xznn3f515dcakh869di1rh-rocq-core9.0-corn-dev'
Error: Process completed with exit code 1.

@andres-erbsen

Copy link
Copy Markdown
Collaborator Author

Dear coq-nix-toolbox maintainers, @CohenCyril @Zimmi48: Can you (easily) help me tell what the CI is complaining about here? See overlay declaration, code. Thanks!

@andres-erbsen andres-erbsen marked this pull request as ready for review June 5, 2025 17:07
@proux01

proux01 commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Sorry for the delayed answer. The message seems to tell that corn didn't compile/install anything. We should try to understand why (maybe they recently modified something in their build system?).

@proux01

proux01 commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Indeed the lines

Running phase: configurePhase
no configure script, doing nothing

should be something like (c.f. for instance https://github.com/rocq-prover/stdlib/actions/runs/15546209619/job/43768830203 )

Running phase: configurePhase
patching script interpreter paths in ./configure.sh
./configure.sh: interpreter directive changed from "#!/usr/bin/env sh" to "/nix/store/xg75pc4yyfd5n2fimhb98ps910q5lm5n-bash-5.2p37/bin/sh"
configure flags: ''

But not sure what's happening since your overlay branch still contains the configure.sh file?

Comment thread .nix/config.nix Outdated
rocq-elpi.override.version = "master";
rocq-elpi.override.elpi-version = "2.0.7";
rocq-elpi-test.override.version = "master";
corn.override.version = "andres-erbsen:patch-1";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I found it, could you try moving this line up 6 lines above (just below the comment) so that it is in coq-common-bundles and not in common-bundles

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(common-bundles applies to both coq and rocq, and since there is no corn in rocq, strange things happen if we add an empty package there)

@andres-erbsen

Copy link
Copy Markdown
Collaborator Author

fiat-crypto says Makefile:27: etc/coq-scripts/Makefile.vo_closure: No such file or directory

@proux01

proux01 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

IIRC (check in .nix/coq-overlays/fiat-crypto) putting an overlay in any other repo than the main one disactivates all the git submodule churn, so you may need to add overlays for those dependencies or something like that.

@andres-erbsen

Copy link
Copy Markdown
Collaborator Author

Thank you! I don't understand why the behavior arises or how it makes sense, but sure seems to work as you advised.

@andres-erbsen andres-erbsen merged commit 0fb9f60 into rocq-prover:master Jun 14, 2025
238 checks passed
proux01 added a commit to rocq-community/rocq-lean-import that referenced this pull request Jun 16, 2025
proux01 added a commit to rocq-community/rocq-lean-import that referenced this pull request Jun 16, 2025
mrhaandi added a commit to uds-psl/coq-library-undecidability that referenced this pull request Jul 21, 2025
@proux01 proux01 added this to the 9.1 milestone Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants