-
Notifications
You must be signed in to change notification settings - Fork 0
Extract Age structure data from world pop #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks super cool!
@TjebbeH I left some comments here and there. Also, as we discussed, it would be good to address the following:
- The list of countries in the config file does not necessarily coincide with the list of countries for which we should download raster data. In fact, that depends on the intersection between the country polygons, respectively according to our definition and WP definition.
- Related to the item above, Extract should also take care of downloading the WP country borders, in order to compute intersections.
@p-phung I don't think you need to check everything, but maybe pay attention to the following items:
- I didn't check much the methods (and related tests) in
blob_storage, as I'm not familiar with those; - I find the structure of the pipeline very clear, but it does have some differences with the flood pipeline. I'll leave to you to judge whether this is a concern or not.
Simplify Api json extractor
@castledan I'll do both in next PRs ok? As that would be easier when I have the ibf boundaries extraction inplemented. |
p-phung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice and clear for me. Well done @TjebbeH.
I run a test locally. No error at all. Only a few warnings like one below. Is it expected?
WARNING | retrievalpipeline.extract.api_json_extractor:validate_and_parse:119 - data retrieved from api does not have the expected schema: 1 validation error for AgeStructureSchema
files
Value error, group '_m_1_' not found in files [type=value_error, input_value=['https://data.worldpop.o...O/LSO_SAP_1km_2020.zip'], input_type=list]
Yes it's expected. Here i think it's because i didnt want to put 36 files in the test as this was not needed for the thing i wanted to test. Sometimes the printed warnings of tests also come from test that test if a 'bad' situation is handled correctly (search for tests with |
Related countries (ibf <-> wp) and restrict number of simultaneous downloads


Uh oh!
There was an error while loading. Please reload this page.